Skip to content

Conversation

diegmonti
Copy link

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

No changes to security controls.

Description

  • Allow aws_backup_plan advanced_backup_setting blocks to accept the S3 resource type.
  • Document the S3 usage pattern in both Terraform and CDKTF guides.

Relations

References

Output from Acceptance Testing

% make testacc TESTS=TestAccBackupPlan_advancedBackupSetting PKG=backup
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-advanced_backup_settings 🌿...
TF_ACC=1 go1.24.6 test ./internal/service/backup/... -v -count 1 -parallel 20 -run='TestAccBackupPlan_advancedBackupSetting'  -timeout 360m -vet=off
2025/09/26 11:16:46 Creating Terraform AWS Provider (SDKv2-style)...
2025/09/26 11:16:46 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccBackupPlan_advancedBackupSetting
=== PAUSE TestAccBackupPlan_advancedBackupSetting
=== CONT  TestAccBackupPlan_advancedBackupSetting
--- PASS: TestAccBackupPlan_advancedBackupSetting (19.68s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/backup     19.777s

@diegmonti diegmonti requested a review from a team as a code owner September 29, 2025 12:37
Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

Copy link
Contributor

github-actions bot commented Sep 29, 2025

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/backup Issues and PRs that pertain to the backup service. size/S Managed by automation to categorize the size of a PR. labels Sep 29, 2025
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 29, 2025
@diegmonti diegmonti force-pushed the f-advanced_backup_settings branch from 9e83049 to 310b389 Compare September 30, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/backup Issues and PRs that pertain to the backup service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants