Skip to content

F make sqs wait times configurable 34787 #44451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

F make sqs wait times configurable 34787 #44451

wants to merge 4 commits into from
+137 −13

Conversation

JackMcBride98
Copy link

Rollback Plan

N/A

Changes to Security Controls

N/A

Description

Make sqs wait times configurable for the benefit of increasing local development speed. See #34787

Relations

Closes #34787

Output from Acceptance Testing

@JackMcBride98 JackMcBride98 requested a review from a team as a code owner September 25, 2025 12:55
@github-actions GitHub Actions
Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 25, 2025 •
edited
Loading

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/sqs Issues and PRs that pertain to the sqs service. provider Pertains to the provider itself, rather than any interaction with AWS. client-connections Pertains to the AWS Client and service connections. size/L Managed by automation to categorize the size of a PR. labels Sep 25, 2025
@srsholmes
Copy link

Great work, thanks!

leonaves
leonaves approved these changes Sep 25, 2025
View reviewed changes
Copy link

@leonaves leonaves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ewbankkit ewbankkit added localstack LocalStack-specific issues and PRs. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@leonaves leonaves leonaves approved these changes

@srsholmes srsholmes srsholmes approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. localstack LocalStack-specific issues and PRs. provider Pertains to the provider itself, rather than any interaction with AWS. service/sqs Issues and PRs that pertain to the sqs service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Reduce SQS verification
4 participants
@JackMcBride98 @srsholmes @leonaves @ewbankkit