Skip to content

Conversation

medhatelhady
Copy link

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

AWS has functionality to add additional data sources to the model while building an endpoint. This functionality was not implemented in the provider

Relations

Closes #43814

References

https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/sagemaker/client/create_model.html

Output from Acceptance Testing

% make testacc TESTS=TestAccSageMakerModel_primaryContainerAdditionalModelDataSources PKG=sagemaker

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-aws-sagemaker-model-additional-model-data-source 🌿...
TF_ACC=1 go1.24.6 test ./internal/service/sagemaker/... -v -count 1 -parallel 20 -run='TestAccSageMakerModel_primaryContainerAdditionalModelDataSources'  -timeout 360m -vet=off
2025/09/23 01:20:22 Creating Terraform AWS Provider (SDKv2-style)...
2025/09/23 01:20:22 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccSageMakerModel_primaryContainerAdditionalModelDataSources
=== PAUSE TestAccSageMakerModel_primaryContainerAdditionalModelDataSources
=== CONT  TestAccSageMakerModel_primaryContainerAdditionalModelDataSources
--- PASS: TestAccSageMakerModel_primaryContainerAdditionalModelDataSources (60.83s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker  61.046s
...

@medhatelhady medhatelhady requested a review from a team as a code owner September 22, 2025 22:26
Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/L Managed by automation to categorize the size of a PR. labels Sep 22, 2025
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for AdditionModelDataSource in aws_sagemaker_model Resource

2 participants