Skip to content

Add resource identity to glue #43450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add resource identity to glue #43450

wants to merge 6 commits into from

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Jul 18, 2025

Description

Add resource identity to ARN-based resources in glue. This includes:

  • aws_glue_registry
  • aws_glue_schema

Relations

Relates #42983
Relates #42984

Output from Acceptance Testing

make testacc PKG=glue TESTS=TestAccGlueRegistry_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.5 test ./internal/service/glue/... -v -count 1 -parallel 20 -run='TestAccGlueRegistry_'  -timeout 360m -vet=off
--- PASS: TestAccGlueRegistry_disappears (17.50s)
--- PASS: TestAccGlueRegistry_basic (28.00s)
--- PASS: TestAccGlueRegistry_description (30.09s)
--- PASS: TestAccGlueRegistry_Identity_RegionOverride (35.09s)
--- PASS: TestAccGlueRegistry_Identity_Basic (38.08s)
--- PASS: TestAccGlueRegistry_tags (38.74s)
--- PASS: TestAccGlueRegistry_Identity_ExistingResource (45.44s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/glue     51.215s

make testacc PKG=glue TESTS=TestAccGlueSchema_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.5 test ./internal/service/glue/... -v -count 1 -parallel 20 -run='TestAccGlueSchema_'  -timeout 360m -vet=off
--- PASS: TestAccGlueSchema_Disappears_registry (25.47s)
--- PASS: TestAccGlueSchema_disappears (27.89s)
--- PASS: TestAccGlueSchema_json (29.73s)
--- PASS: TestAccGlueSchema_basic (30.30s)
--- PASS: TestAccGlueSchema_protobuf (31.67s)
--- PASS: TestAccGlueSchema_Identity_Basic (36.95s)
--- PASS: TestAccGlueSchema_description (39.95s)
--- PASS: TestAccGlueSchema_compatibility (41.53s)
--- PASS: TestAccGlueSchema_schemaDefUpdated (42.30s)
--- PASS: TestAccGlueSchema_Identity_RegionOverride (43.49s)
--- PASS: TestAccGlueSchema_Identity_ExistingResource (51.65s)
--- PASS: TestAccGlueSchema_tags (52.89s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/glue     58.727s

@jar-b jar-b requested a review from a team as a code owner July 18, 2025 19:47
Copy link

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/iam Issues and PRs that pertain to the iam service. service/glue Issues and PRs that pertain to the glue service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. size/M Managed by automation to categorize the size of a PR. generators Relates to code generators. size/XL Managed by automation to categorize the size of a PR. labels Jul 18, 2025
@jar-b jar-b changed the title Add resource identity to glue Add resource identity to glue Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/glue Issues and PRs that pertain to the glue service. service/iam Issues and PRs that pertain to the iam service. size/M Managed by automation to categorize the size of a PR. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant