Skip to content

Add authentication_method and service_access_role_arn to postgres_settings for aws_dms_endpoint #43440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dacohen
Copy link

@dacohen dacohen commented Jul 18, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

This PR adds the authentication_method and service_access_role_arn settings to the postgres_settings block for aws_dms_endpoint. These are necessary for using IAM authentication with a DMS Endpoint.

Relations

Closes #43289

References

Output from Acceptance Testing

% make testacc TESTS=TestAccDMSEndpoint_PostgreSQL_settings PKG=dms

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.5 test ./internal/service/dms/... -v -count 1 -parallel 20 -run='TestAccDMSEndpoint_PostgreSQL_settings'  -timeout 360m -vet=off
2025/07/17 23:15:15 Creating Terraform AWS Provider (SDKv2-style)...
2025/07/17 23:15:15 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccDMSEndpoint_PostgreSQL_settings_source
=== PAUSE TestAccDMSEndpoint_PostgreSQL_settings_source
=== RUN   TestAccDMSEndpoint_PostgreSQL_settings_target
=== PAUSE TestAccDMSEndpoint_PostgreSQL_settings_target
=== CONT  TestAccDMSEndpoint_PostgreSQL_settings_source
=== CONT  TestAccDMSEndpoint_PostgreSQL_settings_target
--- PASS: TestAccDMSEndpoint_PostgreSQL_settings_target (123.34s)
--- PASS: TestAccDMSEndpoint_PostgreSQL_settings_source (123.71s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dms        128.146s

…s_settings` in `aws_dms_endpoint` resource.
@dacohen dacohen requested a review from a team as a code owner July 18, 2025 03:18
Copy link

github-actions bot commented Jul 18, 2025

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

Copy link

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/dms Issues and PRs that pertain to the dms service. size/S Managed by automation to categorize the size of a PR. labels Jul 18, 2025
@github-actions github-actions bot added the size/M Managed by automation to categorize the size of a PR. label Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. needs-triage Waiting for first response or review from a maintainer. service/dms Issues and PRs that pertain to the dms service. size/M Managed by automation to categorize the size of a PR. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support IAM Authentication on aws_dms_endpoint
1 participant