Bootstrap the server using the official mcp go-sdk#348
Open
Shweta-Deshpande wants to merge 17 commits into
Open
Bootstrap the server using the official mcp go-sdk#348Shweta-Deshpande wants to merge 17 commits into
Shweta-Deshpande wants to merge 17 commits into
Conversation
jaylonmcshan19-x
previously approved these changes
May 4, 2026
jaylonmcshan19-x
left a comment
jaylonmcshan19-x
left a comment
Contributor
There was a problem hiding this comment.
LGTM. PR #337 adds a security check that blocks TFE_ADDRESS headers when TFE_TOKEN comes from env var. Once that merges, the new helper will need the same logic I believe
3 tasks
| WildcardName string `json:"wildcard_name,omitempty" jsonschema:"Wildcard pattern"` | ||
| } | ||
|
|
||
| mcp.AddTool(svr, &mcp.Tool{ |
Contributor
There was a problem hiding this comment.
Quick question! what's the plan for testing the new SDK tools? I believe the existing tests check tool creation via the returned ServerTool struct, but with mcp.AddTool() being inline, I think we might need a different approach.
Collaborator
Author
There was a problem hiding this comment.
Yeah will look into it and create a new ticket and PR for that.
Collaborator
Author
There was a problem hiding this comment.
Correction: migration of existing e2e tests will also be done via this PR. Thanks @jaylonmcshan19-x
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| # dev runs the binary from devbuild | ||
| # ----------------------------------- | ||
| # Make a stage to run the app | ||
| FROM scratch AS dev |
|
|
||
| # default release image (refereced in .github/workflows/build.yml) | ||
| # ----------------------------------- | ||
| FROM scratch AS release-default |
| # Set default target to 'dev'. | ||
| # | ||
| # =================================== | ||
| FROM dev |
Shweta-Deshpande
force-pushed
the
TFECO-12234
branch
from
a49a798 to
1a3cabc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PCI review checklist
I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.