Skip to content

Update iframe to VideoEmbed #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update iframe to VideoEmbed #866

wants to merge 2 commits into from

Conversation

im2nguyen
Copy link
Contributor

What

This updates the existing iframe for youtube to a VideoEmbed component. This is so we can standardize how we are serving and tracking video plays across DevDot.

Related PR: hashicorp/dev-portal#2699

Testing instructions

  1. Go to dev-portal and check out the video-embed-posthog-tracking branch
  2. Build the image locally (docker build . -t dev-portal-video-tracking)
  3. Update DOCKER_IMAGE_LOCAL="dev-portal-local" in this repo's website/Makefile file to dev-portal-video-tracking.
  4. Start local preview (make website/local). You may need to add .env.local to website.
  5. Navigate to /terraform/cloud-docs/recommended-practices
  6. Verify the videoembed works as expected, check posthog to see if video_play event is triggered
image

Why

Screenshots


Merge Checklist

If items do not apply to your changes, add (N/A) and mark them as complete.

Pull Request

  • One or more labels describe the type of change (e.g. clarification) and associated product (e.g. HCP Terraform ).
  • Description links to related pull requests or issues, if any.

Content

  • Redirects have been added to website/redirects.js for moved, renamed, or deleted pages.
  • API documentation and the API Changelog have been updated.
  • Links to related content where appropriate (e.g., API endpoints, permissions, etc.).
  • Pages with related content are updated and link to this content when appropriate.
  • Sidebar navigation files have been updated for added, deleted, reordered, or renamed pages.
  • New pages have metadata (page name and description) at the top.
  • New images are 2048 px wide. They have HashiCorp standard annotation color (#F92672) and format (rectangle with rounded corners), blurred sensitive details (e.g. credentials, usernames, user icons), and descriptive alt text in the markdown for accessibility.
  • New code blocks have the correct syntax and line breaks to eliminate horizontal scroll bars.
  • UI elements (button names, page names, etc.) are bolded.
  • The Vercel website preview successfully deployed.

Reviews

  • I or someone else reviewed the content for technical accuracy.
  • I or someone else reviewed the content for typos, punctuation, spelling, and grammar.

Copy link

vercel bot commented Mar 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
terraform-docs-common ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2025 9:22pm

Copy link
Contributor

@ritsok ritsok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants