Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This updates the existing iframe for youtube to a
VideoEmbed
component. This is so we can standardize how we are serving and tracking video plays across DevDot.Related PR: hashicorp/dev-portal#2699
Testing instructions
dev-portal
and check out thevideo-embed-posthog-tracking
branchdocker build . -t dev-portal-video-tracking
)DOCKER_IMAGE_LOCAL="dev-portal-local"
in this repo'swebsite/Makefile
file todev-portal-video-tracking
.make website/local
). You may need to add.env.local
towebsite
./terraform/cloud-docs/recommended-practices
video_play
event is triggeredWhy
Screenshots
Merge Checklist
If items do not apply to your changes, add (N/A) and mark them as complete.
Pull Request
Content
website/redirects.js
for moved, renamed, or deleted pages.Reviews