Skip to content

Backport of test: Fill the allocation prefix list test. into release/1.10.x #26976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2025
Merged

Backport of test: Fill the allocation prefix list test. into release/1.10.x #26976

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 48 additions & 32 deletions api/allocations_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ package api

import (
"context"
"errors"
"fmt"
"os"
"sort"
Expand All @@ -14,6 +15,7 @@ import (
"github.com/hashicorp/nomad/api/internal/testutil"
"github.com/shoenig/test"
"github.com/shoenig/test/must"
"github.com/shoenig/test/wait"
)

func TestAllocations_List(t *testing.T) {
Expand Down Expand Up @@ -60,46 +62,60 @@ func TestAllocations_List(t *testing.T) {
}

func TestAllocations_PrefixList(t *testing.T) {
testutil.RequireRoot(t)
testutil.Parallel(t)

c, s := makeClient(t, nil, nil)
defer s.Stop()
a := c.Allocations()
testAPIClient, testServer := makeClient(t, nil, func(c *testutil.TestServerConfig) { c.DevMode = true })
t.Cleanup(testServer.Stop)
_ = oneNodeFromNodeList(t, testAPIClient.Nodes())

// Querying when no allocs exist returns nothing
allocs, qm, err := a.PrefixList("")
allocs, qm, err := testAPIClient.Allocations().PrefixList("")
must.NoError(t, err)
must.Zero(t, qm.LastIndex)
must.Len(t, 0, allocs)

// TODO: do something that causes an allocation to actually happen
// so we can query for them.
return

//job := &Job{
//ID: stringToPtr("job1"),
//Name: stringToPtr("Job #1"),
//Type: stringToPtr(JobTypeService),
//}

//eval, _, err := c.Jobs().Register(job, nil)
//if err != nil {
//t.Fatalf("err: %s", err)
//}

//// List the allocations by prefix
//allocs, qm, err = a.PrefixList("foobar")
//if err != nil {
//t.Fatalf("err: %s", err)
//}
//if qm.LastIndex == 0 {
//t.Fatalf("bad index: %d", qm.LastIndex)
//}

//// Check that we got the allocation back
//if len(allocs) == 0 || allocs[0].EvalID != eval {
//t.Fatalf("bad: %#v", allocs)
//}
// Create a job and register it
job := testJob()
resp, wm, err := testAPIClient.Jobs().Register(job, nil)
must.NoError(t, err)
must.NotNil(t, resp)
must.UUIDv4(t, resp.EvalID)
assertWriteMeta(t, wm)

// Get a list of the job allocations, so we have data to move onto prefix
// matching.
must.Wait(t, wait.InitialSuccess(
wait.ErrorFunc(
func() error {
allocs, _, err := testAPIClient.Jobs().Allocations(*job.ID, false, nil)
if err != nil {
return err
}
if len(allocs) != 1 {
return errors.New("waiting for job allocations")
}
return nil
},
),
wait.Timeout(5*time.Second),
wait.Gap(100*time.Millisecond),
))
jobAllocs, _, err := testAPIClient.Jobs().Allocations(*job.ID, false, nil)
must.NoError(t, err)
must.Len(t, 1, jobAllocs)

// Perform a test of prefix matching by using the first 4 characters which
// should be more than enoigh to be unique and give a consistent result.
allocs, _, err = testAPIClient.Allocations().PrefixList(jobAllocs[0].ID[:4])
must.NoError(t, err)
must.Len(t, 1, allocs)
must.Eq(t, jobAllocs[0].ID, allocs[0].ID)

// Test a prefix that does not match anything.
allocs, _, err = testAPIClient.Allocations().PrefixList(generateUUID())
must.NoError(t, err)
must.Len(t, 0, allocs)
}

func TestAllocations_List_Resources(t *testing.T) {
Expand Down