Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[F-net-11478] Make keys directory cluster grouped #24883

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Juanadelacuesta
Copy link
Member

@Juanadelacuesta Juanadelacuesta commented Jan 16, 2025

Description

As part of the adjustments to use the e2e terraform provisioning as a module and to be able to run multiple clusters concurrently, all the TLS and SSH resources need to be placed in a different folder so they are not overwritten by running the same module multiple times, this PR introduces a folder per cluster for all TLS, SSH and bootstratp tokens used during provisioning.

It also expands the usage of the instance_arch to windows machines.

Testing & Reproduction steps

Links

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
  • Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
    and job configuration, please update the Nomad website documentation to reflect this. Refer to
    the website README for docs guidelines. Please also consider whether the
    change requires notes within the upgrade guide.

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.

@Juanadelacuesta Juanadelacuesta requested review from a team as code owners January 16, 2025 22:08
@Juanadelacuesta Juanadelacuesta force-pushed the f-NET-11478-keys branch 2 times, most recently from 9b161a6 to 1629913 Compare January 16, 2025 22:11
@Juanadelacuesta Juanadelacuesta added backport/ent/1.9.x+ent Changes are backported to 1.9.x+ent backport/1.9.x backport to 1.9.x release line and removed backport/ent/1.9.x+ent Changes are backported to 1.9.x+ent labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.9.x backport to 1.9.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant