Fix policy manager restart due to a monitor failing #1207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to Needs Triage
in Nomad - Community Issues Triage
Member
|
Hi @waquidvp and thanks for raising this PR. I suspect reverting the change will re-introduce the identified memory leak, so we will want to find a different solution. I'll keep this PR open, so whoever looks into the linked issue can see the full detail and decide how to move forward. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1206
This reverts part of a change made in #1140. The description on that PR mentions:
However, this causes the monitorCtx to remain cancelled for subsequent iterations which as seen in the linked issue can cause the monitor to not start again after failing once.
I am however not sure if the memory leak mentioned in the original change would now be introduced again. If the
deferis what would cause it, thedefercould be removed since cancel is called later.