require only ipv4 or ipv6 success for sendQuery success #121
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
serf's
TestCommandRun_mDNS
on my macOS M1 fails becausesendQuery
fails due to:this will fail because the ipv6 multicast connection doesn't bind to a specific interface.
in this case
config.Iface
is nil.however, this is successful
even though
ipv4List
is created withnil
iface. multicast works for ipv4 atlo0
interface and it doesn't require specific interface binding.sendQuery
should be considered success with just one successful send. if it is successful on ipv4 but unsuccessful on ipv6, it's ok to proceed. if it is unsuccessful on ipv4 but successful on ipv6? that's unlikely, but still ok to proceed.