Skip to content

terraform-search-import: more tidying before import#65

Closed
bbasata wants to merge 2 commits intomainfrom
terraform-tidy-for-import
Closed

terraform-search-import: more tidying before import#65
bbasata wants to merge 2 commits intomainfrom
terraform-tidy-for-import

Conversation

@bbasata
Copy link
Copy Markdown
Collaborator

@bbasata bbasata commented Apr 16, 2026

@bbasata bbasata marked this pull request as ready for review April 16, 2026 19:17
@bbasata bbasata requested a review from a team as a code owner April 16, 2026 19:17
@github-actions
Copy link
Copy Markdown

Tessl Skill Review Results

Skill Status Review Score Change
terraform/code-generation/skills/terraform-search-import ✅ PASSED 88%

Detailed Review

terraform/code-generation/skills/terraform-search-import — 88% (PASSED)
  Description: 92%
    \(.key): \(.value.score)/3 - \(.value.reasoning)
    \(.key): \(.value.score)/3 - \(.value.reasoning)
    \(.key): \(.value.score)/3 - \(.value.reasoning)
    \(.key): \(.value.score)/3 - \(.value.reasoning)

    Assessment: This is a well-structured description that clearly communicates both what the skill does and when to use it, with a good 'Use when...' clause covering multiple scenarios. The trigger terms are natural and cover relevant user language. The main weakness is that the 'what' portion could be more specific about the concrete actions performed (e.g., generating import blocks, writing HCL configuration).

  Content: 83%
    \(.key): \(.value.score)/3 - \(.value.reasoning)
    \(.key): \(.value.score)/3 - \(.value.reasoning)
    \(.key): \(.value.score)/3 - \(.value.reasoning)
    \(.key): \(.value.score)/3 - \(.value.reasoning)

    Assessment: This is a solid, actionable skill with comprehensive executable examples covering basic through advanced Terraform Search usage. Its main weaknesses are some redundancy between sections (discovery commands repeated) and insufficient validation/feedback loops in the post-generation cleanup workflow, which is critical for a bulk import operation. The progressive disclosure and overall structure are well done.

Suggestions:

  • Add more specific concrete actions to the capability description, e.g., 'generate import blocks, write HCL configuration, reconcile state' to improve specificity.
  • Remove the redundant 'Prerequisites > Discover Available List Resources' section since the same commands appear in the 'Check Provider Support First' section above it.
  • Add explicit validation checkpoints in the post-generation cleanup workflow, e.g., 'Run terraform validate after each cleanup step' and 'If plan shows drift, review removed attributes and re-clean before applying'.
  • Remove or consolidate the empty 'Supported List Resources' section — it just says to check the script, which is already stated twice above.

Checks: frontmatter validity, required fields, body structure, examples, line count.
Review score is informational — not used for pass/fail gating.

@bbasata
Copy link
Copy Markdown
Collaborator Author

bbasata commented Apr 18, 2026

Closing. Making this better in #66.

@bbasata bbasata closed this Apr 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant