docs: add integrity warning to Chocolatey iex install example#58
Open
xiaolai wants to merge 1 commit intohashicorp:mainfrom
Open
docs: add integrity warning to Chocolatey iex install example#58xiaolai wants to merge 1 commit intohashicorp:mainfrom
xiaolai wants to merge 1 commit intohashicorp:mainfrom
Conversation
The `iex ((New-Object System.Net.WebClient).DownloadString(...))` pattern executes a remote script in memory without any integrity check — the PowerShell equivalent of curl|sh. Add a comment in the example directing users to verify the script or use the official signed installer for production image builds. Co-Authored-By: Claude Code <noreply@anthropic.com>
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
packer/builders/skills/windows-builder/SKILL.md(line 106) shows a Chocolatey install using theiex+DownloadStringpattern:This is the PowerShell equivalent of
curl | sh— it fetches and executes a remote script entirely in memory, with no integrity check (no checksum, no signature verification). When this pattern appears in a documentation example without a caveat, it can lead users to adopt it in production image builds without understanding the risk.Fix
Add a comment block before the provisioner explaining the risk and pointing to the Chocolatey docs for more secure alternatives (signed installer, checksum verification). The example code itself is unchanged — only a warning comment is added.
Why it matters
Packer templates are often used to build golden AMIs or base images for production workloads. Users following this example in a CI/CD pipeline would silently accept whatever
community.chocolatey.orgserves at build time, with no audit trail. A brief note helps users make an informed choice without removing a useful example.No functional code was changed in this PR.