Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and adapt to tonic best practice #1

Merged
merged 2 commits into from
May 30, 2022

Conversation

bachp
Copy link
Contributor

@bachp bachp commented Mar 24, 2022

This is a refresh to bring the dependencies up to date.

Copy link
Owner

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bachp thanks for the updates and apologies for the delayed response! One question below but otherwise LGTM :)

plugin/Cargo.toml Outdated Show resolved Hide resolved
bachp added 2 commits May 30, 2022 14:01
This avoids polluting the source tree.

Signed-off-by: Pascal Bach <[email protected]>
@bachp bachp force-pushed the dependency-updates branch from b75f03a to b14f805 Compare May 30, 2022 12:02
@hasheddan hasheddan merged commit 9c6dbd8 into hasheddan:main May 30, 2022
@bachp bachp deleted the dependency-updates branch May 30, 2022 12:40
@bachp
Copy link
Contributor Author

bachp commented May 30, 2022

@hasheddan Will you do a new release on crates.io?

@hasheddan
Copy link
Owner

@bachp I would be happy to 👍🏻 Are you currently consuming this crate in a project?

@bachp
Copy link
Contributor Author

bachp commented May 31, 2022

@hasheddan Yes I'm using it on a device plugin prototype. Currently I have a copy but if a new release was done I can switch to it.

The second issue currently preventing rust from being used out of the box for this is hyperium/h2#612

@hasheddan
Copy link
Owner

@bachp awesome, I'll try to get a release out today 👍🏻

@hasheddan
Copy link
Owner

@bachp release is out https://crates.io/crates/k8s-deviceplugin/0.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants