Forge + board steps: gh/glab queues, board scan, chores check#3
Merged
Conversation
WHAT: Seven new builtin step types. gitlab.rs: gitlab-mr-authored / gitlab-mr-review (glab mr list per project), gitlab-group-mrs (--per-page; scan=recent adds a 7-day --created-after window), and the derived mr-sla-check (counts pending review projects from this run's prior results; response_hours param). github.rs: github-pr-scan (gh pr list --json number,title,author,updatedAt → compact lines). board.rs: board-scan (### lane (N tasks) + stems per lane) and chores-check (due:/Due: YYYY-MM-DD lines → OVERDUE/due-today/upcoming buckets). Auth failures (401/unauthorized/forbidden/gh-auth-login hint) are soft: all-failed → skip with the exact login command; partial → auth noise filtered, real results kept (Python-handler parity). ALL forge steps now resolve spec.env credential references and inject them into the subprocess env (missing credential → soft skip naming the variable, never a value). Example config grows the review-queue and board phases. WHY: Phase 2/4/5 of the morning routine from gilabot#1892, ported from gila-plugin-morning's proven handlers. The spec.env wiring was a fresh-eyes catch: the example showed credentials on forge steps that the handlers silently ignored. 93 tests total. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #2 — retarget after it merges.
Seven new builtin step types completing the morning routine's repo-external phases:
glab mr list --author/--reviewerper configured project, text passthrough (the proven Python contract)scan = "recent"adds a 7-day--created-afterwindowresponse_hoursthresholdgh pr list --json→ compact#N title (author)linesdue: YYYY-MM-DDlines into OVERDUE / due-today / upcomingFailure semantics carried through: auth failures are soft (all-failed → skip with the exact
glab auth login --hostname …/gh auth logincommand; partial → noise filtered, real results kept).Fresh-eyes catch included: forge steps were ignoring
spec.env— credential references now resolve and inject on every gh/glab spawn, with a soft skip naming the variable (never a value) when one is unavailable. Regression tests cover it.Test plan
just checkgreen: 93 tests, clippy-D warningscleanjust demodry-run renders the full extended morning routine