-
Couldn't load subscription status.
- Fork 3
Add new DeviceReader constructors #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bruno-f-cruz
wants to merge
47
commits into
main
Choose a base branch
from
feat-device-reader-constructors
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+314
−11
Open
Changes from all commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
b64f17f
Add new constructor methods
bruno-f-cruz ebd1956
Deprecate function
bruno-f-cruz 2e51fc4
Document methods
bruno-f-cruz 24b8977
Linting
bruno-f-cruz 9c8bb7d
Add new constructor methods
bruno-f-cruz a890991
Deprecate function
bruno-f-cruz 1b3d438
Document methods
bruno-f-cruz a76c6f0
Linting
bruno-f-cruz dbdbaa3
Merge branch 'feat-device-reader-constructors' of https://github.com/…
bruno-f-cruz 828cd3b
Fix rebasing
bruno-f-cruz 13a6862
Add deprecated decorator
bruno-f-cruz 3cefa8e
Fix rebasing
bruno-f-cruz 89870d9
Favor library's deprecated decorator
bruno-f-cruz 83397d1
Linting
bruno-f-cruz 48dadeb
Add requests as dependency
bruno-f-cruz 4c39bd8
Move decorator to separate private helper module to prevent circular …
bruno-f-cruz 132cb73
Ignore warnings emitted by deprecated decorator
bruno-f-cruz 59258e7
Merge branch 'main' into feat-device-reader-constructors
bruno-f-cruz 30ecc6b
Favor stdlib decorator
bruno-f-cruz c09c573
Refactor to #40
bruno-f-cruz cc258c1
Linting
bruno-f-cruz 02059bf
Make `data` input to `_compose_parser` optional
bruno-f-cruz 6a882c2
Add unittest for registers with payload spec
bruno-f-cruz 3ee94ae
Suppress `pyright` error on internal method import
bruno-f-cruz f6f4c53
Merge pull request #46 from harp-tech/fix-parser
glopesdev 204b225
Replace license classifier with SPDX expression
glopesdev 3d97d0b
Merge pull request #47 from harp-tech/license-spdx
glopesdev edd9415
Add new constructor methods
bruno-f-cruz 7662754
Deprecate function
bruno-f-cruz ceaa56d
Document methods
bruno-f-cruz 7c8e5b4
Linting
bruno-f-cruz b5160a8
Add deprecated decorator
bruno-f-cruz 58f3a0b
Linting
bruno-f-cruz a9cea29
Add requests as dependency
bruno-f-cruz b4abcaa
Move decorator to separate private helper module to prevent circular …
bruno-f-cruz e00c784
Ignore warnings emitted by deprecated decorator
bruno-f-cruz 5a2b409
Favor stdlib decorator
bruno-f-cruz 70cea11
Refactor to #40
bruno-f-cruz 6ad34ec
Merge branch 'feat-device-reader-constructors' of https://github.com/…
bruno-f-cruz d063806
Linting
bruno-f-cruz 724bca1
Import deprecated from typing_extensions
bruno-f-cruz 7a4a81a
Ensure device_name is appended to base_path
bruno-f-cruz 1e075ee
Add unittest
bruno-f-cruz c4db137
Add string type hinting to paths
bruno-f-cruz f6843d2
Refactor unions to legacy syntax
bruno-f-cruz b1c522e
Ensure request errors are raised from reader
bruno-f-cruz 3dfa3e6
Shorten deprecation warning
bruno-f-cruz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still looking for a better name:
from_yaml: may be misleading since the others also ultimately use YAMLfrom_schema: maybe a little bit betterThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from_schemamakes me nervous as people might think you should pass the actuall schema file (i.e..yml). Wouldfrom_stringbe better (ToStringis also a thing after all haha)?