-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hw7 done #26
base: master
Are you sure you want to change the base?
hw7 done #26
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
### Первый прогон | ||
|
||
 | ||
|
||
### PARALLEL | ||
|
||
Второй прогон: | ||
 | ||
|
||
|
||
### RSPEC-DISSECT | ||
|
||
Выявил пару жирных let'ов | ||
* Первая оптимизациия: | ||
``` | ||
Finished in 11.115231994 seconds | ||
Process finished with exit code 0 | ||
``` | ||
Использовал `let_it_be` вместо `let!` для генерации сложной структуры | ||
``` | ||
Finished in 3.488940863 seconds | ||
Process finished with exit code 0 | ||
``` | ||
|
||
* Вторая оптимизациия: | ||
``` | ||
Finished in 7.255991587 seconds | ||
``` | ||
``` | ||
Finished in 1.925112093 seconds | ||
``` | ||
|
||
Подтянул еще парочку мест не под запись | ||
|
||
Остальные спеки показались некритичными по длительности, понятное дело, все подряд не оптимизировал, нет столько времени) | ||
|
||
Потыкался в factory-doctor, не стал менять ничего | ||
|
||
Финальное время | ||
``` | ||
7008 examples, 0 failures, 2 pendings | ||
Took 230 seconds (3:50) | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.5x, и время в какие-то весьма более приятные рамки вернулось 👍