igor-arkhipov/performance-improvement-5 #101
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spajic
reviewed
Nov 28, 2023
| "<#{view_context.asset_path('stack.svg')}>; rel=preload; as=image", | ||
| "<#{view_context.asset_path('lightning.svg')}>; rel=preload; as=image", | ||
| ] | ||
| response.headers['Link'] = push_headers.join(', ') |
spajic
reviewed
Nov 28, 2023
| * Без принудительной загрузки картинок время отображения страницы отставало: до первого появления элементов на странице прошло сравнительно одинаковое время 0.27-0.3 сек, однако эти же 0.3 сек позволили оптимизированной версии отрисовать страницу на 98%, когда без `server-push` на это потребовалось 0.43 сек. | ||
| * Для второй загрузки: | ||
| * 0,34 секунды потребовалось версии без оптимизации для отрисовывания первых элементов и 0,4 сек для полной загрузки. Для версии с `server-push` это 0,27 и 0,33 сек соответственно. | ||
| * 9-27 мс против 20-43 мс составило время загрузки изображений, которые мы добавили в первоначальный ответ сервера, это видно в разделе `Waterfall` отчета. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
server-pushдля указанных в задании картинокNGinxвложен в корневую папку проекта (nginx.conf)HAR-файлов сserver-pushи без:https://compare.sitespeed.io/?har1=https://raw.githubusercontent.com/IgorArkhipov/rails-optimization-task5/igor-arkhipov/performance-improvement-5/sitespeed-result/report_with_preloading.har&har2=https://raw.githubusercontent.com/IgorArkhipov/rails-optimization-task5/igor-arkhipov/performance-improvement-5/sitespeed-result/report_without_preloading.har&compare=1