Better http #100
Open
Better http #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peresvetjke
commented
Nov 21, 2023
| @@ -16,7 +16,8 @@ end | |||
| gem "actionpack-action_caching", "~> 1.2" | |||
| gem "active_record_union", "~> 1.3" | |||
| gem "acts-as-taggable-on", "~> 5.0" | |||
| gem "acts_as_follower", github: "thepracticaldev/acts_as_follower", branch: "master" | |||
| # gem "acts_as_follower", github: "thepracticaldev/acts_as_follower", branch: "master" | |||
There was a problem hiding this comment.
Пара гемов оказались не доступны - заменил на одноименные форки.
There was a problem hiding this comment.
блин, странно, мне казалось я это фиксил
There was a problem hiding this comment.
webpage test after
https://www.webpagetest.org/result/231119_BiDcYF_8TG/
Можно заметить, что картинки отобразились криво - судя по всему, inline_svg плохо дружит с кнопками. Навскидку отрехтовать эту часть не смог, но подумал, что это вне объема нашего упражнения.
app/views/articles/index.html.erb
Outdated
| @@ -71,10 +71,10 @@ | |||
| </div> | |||
| </div> | |||
| <button class="on-page-nav-butt on-page-nav-butt-left" id="on-page-nav-butt-left" aria-label="nav-button-left"> | |||
| <img src="<%= asset_path "stack.svg" %>" alt="left-sidebar-nav"> | |||
| <%= inline_svg("stack.svg", size: "100% * 100%", alt: "left-sidebar-nav") %> | |||
There was a problem hiding this comment.
Preload дает эффект:
Ссылки на сравнение sitespeed, кажется, убрали. Поэтому кажется их придется добавить вручную, чтобы посмотреть результат: https://compare.sitespeed.io/
spajic
reviewed
Nov 26, 2023
| "<#{view_context.asset_path('stack.svg')}>; rel=preload; as=image", | ||
| "<#{view_context.asset_path('lightning.svg')}>; rel=preload; as=image", | ||
| ] | ||
| response.headers["Link"] = push_headers.join(", ") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Added to documentation?
[optional] What gif best describes this PR or how it makes you feel?