[codex] Add have-config agent resolver and Hermes profile#9
Merged
Conversation
a2a1044 to
274d125
Compare
There was a problem hiding this comment.
Pull request overview
This PR shifts have-config from managing agent “marketplace/plugin” installs to generating local agent commands/skills/docs via a layered resolver (dotfiles → org standards → optional profile (Hermes) → Context Forge snapshot → local overrides), and adds HappyVertical infrastructure/service documentation plus a Hermes check-setup profile.
Changes:
- Add a Python-based agent resolver (
scripts/hv-agent-resolver.py) + regression test script to materialize commands/skills/docs and produce an install report/lock. - Introduce Hermes profile defaults (
profiles/hermes/*) includingcheck-setupcommand/skill and Hermes detection behavior. - Remove legacy Claude/Codex plugin marketplace artifacts and update
install.sh+ README to use the new bootstrap/resolution flow.
Reviewed changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| TODO.md | Updates checklist to reflect new resolver/docs/service-registry work. |
| README.md | Re-documents scope and the new install + resolution model. |
| install.sh | Replaces plugin install logic with dotfiles bootstrap + resolver execution (+ dry-run/skip-dotfiles). |
| scripts/hv-agent-resolver.py | New resolver that composes layers, generates files, links into agent homes, writes report/lock. |
| scripts/test-hv-agent-resolver.sh | New regression script exercising layering, Hermes profile, adoption, and env validation. |
| hv/manifest.json | Adds org manifest for docs snippets + env requirements + embedded services. |
| profiles/hermes/manifest.json | Adds Hermes profile manifest for check-setup and Hermes env requirements. |
| profiles/hermes/commands/claude/check-setup.md | Adds Hermes-only Claude command content. |
| profiles/hermes/commands/codex/check-setup.md | Adds Hermes-only Codex command content. |
| profiles/hermes/skills/check-setup/SKILL.md | Adds Hermes-only Codex skill content. |
| agent-doc-snippets/happyvertical-standards.md | Adds org-wide agent standards snippet (layering/runtime/secrets/services). |
| docs/infrastructure.md | Adds human-readable infra/service map and snapshot policy. |
| docs/agent-playbook.md | Adds agent-facing guidance on which service to use for what + setup verification expectations. |
| services/services.json | Adds machine-readable service registry (currently not referenced by resolver). |
| codex/plugins/have/skills/ship/SKILL.md | Removes legacy Codex skill adapter (Context Forge runtime dependency). |
| codex/plugins/have/skills/review-cycle/SKILL.md | Removes legacy Codex skill adapter (Context Forge runtime dependency). |
| codex/plugins/have/commands/ship.md | Removes legacy Codex command adapter. |
| codex/plugins/have/commands/review-cycle.md | Removes legacy Codex command adapter. |
| codex/plugins/have/.codex-plugin/plugin.json | Removes legacy Codex plugin metadata. |
| codex/.agents/plugins/marketplace.json | Removes legacy Codex marketplace definition. |
| claude/have/commands/ship.md | Removes legacy Claude command adapter. |
| claude/have/commands/review-cycle.md | Removes legacy Claude command adapter. |
| claude/have/.claude-plugin/plugin.json | Removes legacy Claude plugin metadata. |
| claude/.claude-plugin/marketplace.json | Removes legacy Claude marketplace definition. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Impact
Consumers can run one entrypoint, have-config/install.sh. Personal dotfiles stay generic, have-config owns HappyVertical policy, Context Forge remains an install-time snapshot source, and machine-local overrides are preserved under ~/.config/hv/overrides or ~/.hermes/overrides. Non-Hermes installs do not receive check-setup; Hermes installs do.
Hermes detection
Validation
Paired work