Feature: add inner text / html support#6
Open
DamChtlv wants to merge 5 commits into
Open
Conversation
Author
|
Actually, i still need to work on it to add some html support (because text formatting wont be saved, like tags: |
Author
|
Updated screenshots + description, should be good now |
Member
|
Thanks @DamChtlv - I'm hoping to take a look at this soon. We've had a wild couple months. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature
This adds support for
content&textattribute used by most low-level blocks (like heading, paragraph, button...) and so it keeps content inside them (some html tags are filtered, like RichText component does it).It fixes this issue: #5 , it lacks some features still (like button link...) but still better than nothing
Test
Used this HTML gutenberg code to test the feature:
Result
Works for both PHP formatting and JS formatting:
Before:
After: