Code migration from gemini #10
Conversation
There was a problem hiding this comment.
this pull request contains changes and commits that should not be here. I mean adding doc and gitattributes
in general when you create a PR. please review it first on your own before sending it to me. you should have noticed those extra files.
I think this happened because you created this branch from the docu branch not from main or maybe you need to rebase on main. I don't know what you did exactly so can you explain?
packages/happtiq_commons_google_cloud/src/happtiq_commons_google_cloud/gcs_api_service.py
Show resolved
Hide resolved
packages/happtiq_commons_google_cloud/src/happtiq_commons_google_cloud/gcs_api_service.py
Outdated
Show resolved
Hide resolved
packages/happtiq_commons_google_cloud/src/happtiq_commons_google_cloud/gcs_api_service.py
Outdated
Show resolved
Hide resolved
| def test_list_files_with_prefix(gcs_api_service, monkeypatch): | ||
| mock_client = MagicMock() | ||
| mock_bucket = MagicMock() | ||
| mock_blobs = [MagicMock(name="file1.txt"), MagicMock(name="file2.txt")] | ||
|
|
||
| mock_client.bucket.return_value = mock_bucket | ||
| mock_bucket.list_blobs.return_value = mock_blobs | ||
| monkeypatch.setattr(gcs_api_service, "client", mock_client) | ||
|
|
||
| bucket_name = "test-bucket" | ||
| prefix = "test-prefix/" | ||
|
|
||
| result = gcs_api_service.list_files_with_prefix(bucket_name, prefix) | ||
|
|
||
| assert result == ["file1.txt", "file2.txt"] | ||
| mock_client.bucket.assert_called_once_with(bucket_name) | ||
| mock_bucket.list_blobs.assert_called_once_with(prefix=prefix) |
There was a problem hiding this comment.
looks correct. please attach screenshot of the result of test run
There was a problem hiding this comment.
as discussed, I am getting missing attribute error..
There was a problem hiding this comment.
I will fix the test now
There was a problem hiding this comment.
I ran the pytest locally after your correction, but I am getting this error for test_list_files_with_prefix
There was a problem hiding this comment.
interesting I dont have this error
kaanHapptiq
force-pushed
the
code-migration-from-gemini
branch
from
4dae4bf to
41ed9ee
Compare
|
|
I dont know why but I have still this error by testing with 'testpy'
|
kaanHapptiq
force-pushed
the
code-migration-from-gemini
branch
from
f4ca890 to
00b11ef
Compare
kaanHapptiq
had a problem deploying
to
testpypi
GitHub Actions
Failure
kaanHapptiq
had a problem deploying
to
testpypi
GitHub Actions
Failure
kaanHapptiq
had a problem deploying
to
testpypi
GitHub Actions
Failure
kaanHapptiq
had a problem deploying
to
testpypi
GitHub Actions
Failure
kaanHapptiq
temporarily deployed
to
testpypi
GitHub Actions
Inactive
No description provided.