Skip to content

Fix Joi issue #2736: #2845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Joi issue #2736: #2845

wants to merge 1 commit into from

Conversation

martin-petersen
Copy link
Contributor

  • fixes fork which was malfunctioning when schema uses id, the fork rules like, require some property, was not correctly applied.

@martin-petersen
Fix Joi issue 2736:
3e73aee 
   - fixes fork which was malfunctioning when schema uses of, the fork rules like, require some property, was not applied.
@martin-petersen
Copy link
Contributor Author

This PR fixes issue #2736

@martin-petersen martin-petersen marked this pull request as ready for review September 23, 2022 17:35
@Marsup
Copy link
Collaborator

Marsup commented Sep 29, 2022

I feel like it was intentional from the docs If no id is set, the schema id defaults to the object key it is associated with., not sure it was a bug 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tehhowch tehhowch tehhowch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@martin-petersen @Marsup @tehhowch