Node 20 fixes

[kanongil]

This fixes the test suite for node v18, v20 and v21 on my mac.

[kanongil]

Hmm, strange that the macOS runners fail, when they work locally (on M1 macOS 14.1.1).

Looking at the failing tests, it seems that request.active() never returns false.
The "Request active() exits handler early when request is no longer active" test case seems central.

The "Request _postCycle() skips onPreResponse when validation terminates request" test does not directly use request.active() but it might still rely on the internal version of this.

I don't have a macOS 12 machine to test on, so I'm not really able to debug further.

Even stranger, the tests passes on node 18, but fails again on node 20.

[Nargonath]

Looks like we have some flakiness at play here. I restarted the 3 failed macos jobs and now macos node@14 passes whereas it didn't before. This might explain why it works on your machine @kanongil but not in the CI.

[Nargonath]

code LGTM, I had some questions for my own curiosity.

[kanongil]

Looks like we have some flakiness at play here. I restarted the 3 failed macos jobs and now macos node@14 passes whereas it didn't before. This might explain why it works on your machine @kanongil but not in the CI.

Ah, it seems that it only fails on runners using macOS 12.6.9, while runners on macOS 12.7 works. I guess not all macos-latest runners are identical…

I have been doing some experiments, and the tests seem to pass when using the macos-11 or macos-13 (beta) runners, so that might be a way to fix this for now.

[Nargonath]

Thanks for the investigation on the CI. We probably shouldn't block this PR for this and can handle it in another PR.