-
Notifications
You must be signed in to change notification settings - Fork 37
[1주차] 멀티 모듈 구조 사용 및 현재 상영 중인 영화 조회 API 개발 #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sliverzero
wants to merge
30
commits into
hanghae-skillup:main
Choose a base branch
from
sliverzero:week1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
447a175
first commit
JiEunyoung bdce80f
refactor: apply multi-module
JiEunyoung 7da42e3
chore: add docker-compose.yml and ddl.sql
JiEunyoung 2d38082
chore: add application.yml
JiEunyoung f605ac5
chore: remove unused module dependencies
JiEunyoung a8852ed
feat: add module dependencies(for entity)
JiEunyoung 389b0a5
feat: add movie related entities(module-movie)
JiEunyoung 70dea4d
feat: add theater related entities(module-theater)
JiEunyoung 2638a0a
feat: add screening entity(module-screenint)
JiEunyoung 52ae9ce
feat: add screening repository(module-screenint)
JiEunyoung 2e3162d
feat: add screening dto(module-screenint)
JiEunyoung 732f015
feat: add screening service(module-screenint)
JiEunyoung dbd21ff
feat: add screening controller(module-screenint)
JiEunyoung fbe5d2b
chore: add dependencies
JiEunyoung 64918b0
feat: update main class for controller
JiEunyoung 883a139
feat: insert data
JiEunyoung 5e0396e
feat: add auditing
JiEunyoung 267b3d2
feat: add length constraint
JiEunyoung 2cd585d
chore: remove unused dependencies
JiEunyoung f6a2e29
test: add api-test.http
JiEunyoung fc1cb98
chore: update data.sql
JiEunyoung 582694c
chore: update docker-compose.yml for encoding
JiEunyoung 572f7cd
chore: remove unique constraint
JiEunyoung 529302a
refactor: change genre to ENUM type
sliverzero 928a080
refactor: use static factory method in ScreeningDto
sliverzero 0198abc
chore: remove duplicate module dependencies
sliverzero 5637517
chore: remove duplicate module dependencies
sliverzero e4cb260
refactor: week1 refactor(add utf8mb4, module dependencies)
sliverzero e388cb8
fix: modify api response format
sliverzero 40aa523
Update README.md
sliverzero File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
현재는 사용하지 않고 작성된 api 가 없어서 제거한 것이 맞는 것이겠죠? 이후에 추가된다면 상관은 없지면 현재 구조로 간다면 구조를 통일해서 사용하는 것이 좋다고 생각합니다.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
module-theater은 api 작성할 때 사용하지 않은 모듈이라 삭제했습니다!
module-api에 module-theater을 의존하고 있는 module-screening을 추가했고 이후에 api 쪽에 다른 의존성이 추가될 가능성이 적을 것 같습니다.
module-movie, module-theater에도 필요하면 controller, repository, service 작성할 생각으로 도메인별 모듈을 생성했지만 시나리오상 필요하지 않을 것 같아 작성하진 않았습니다. controller, repository, service 이 부분이 작성되기 전 상황은 맞지만 앞으로도 시나리오상 추가하지 않을 것 같다면 구조를 통일시키는 게 좋을까요?
구조를 통일하라는 말씀은 domain만 있던 movie나 theater 모듈을 따로 사용하지 않고 module-common쪽에 domain 패키지로 관리하면 되는 것일까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아하 시나리오상 필요 없어서 현재 필요한 부분에 대해서만 진행하신 것이군요! 도메인 별로 모듈을 구분하였는데 스크리닝 모듈과 다른 무비, 극장 모듈과 같은 레벨의 모듈로 보이는데 스크리닝 모듈에만 service, repository 등등의 구조들이 보이길래 말씀드렸습니다!