[2팀 이정민] Chapter 1-2. AI와 테스트를 활용한 안정적인 기능 개발#11
Closed
LEE-jm96 wants to merge 14 commits intohanghae-plus:mainfrom
Closed
[2팀 이정민] Chapter 1-2. AI와 테스트를 활용한 안정적인 기능 개발#11LEE-jm96 wants to merge 14 commits intohanghae-plus:mainfrom
LEE-jm96 wants to merge 14 commits intohanghae-plus:mainfrom
Conversation
added 14 commits
October 26, 2025 18:31
Collaborator
|
테스트는 통과하셨음 |
joshuayeyo
added a commit
to joshuayeyo/hh-week-2
that referenced
this pull request
Oct 31, 2025
…s#11) ## Test(11): Add failing tests for recurring delete functionality (RED phase) ### 반복 일정 삭제 기능 테스트 추가 (실패) - Add DeleteConfirmDialog component tests (11 test cases) - Add recurring delete utility function tests (15 test cases) - Add useRecurringDelete hook tests (12 test cases) - Add DeleteTypes interface definitions - All tests currently failing as expected in TDD RED phase ## Feat(11): Implement recurring event delete functionality following TDD ### 반복 일정 삭제 기능 TDD 방식으로 구현 - RED phase: 12개 실패 테스트 작성 - GREEN phase: 핵심 로직 구현으로 모든 테스트 통과 달성 - REFACTOR phase: 코드 최적화 및 구조 개선 주요 구현사항: - useRecurringDelete 훅: 메인 삭제 기능 조합 - DeleteConfirmDialog 컴포넌트: 삭제 확인 다이얼로그 - recurringDelete 유틸리티: 권한 검증 및 삭제 로직 - MSW/fetch spy 통합: 테스트 호환성 개선 - 낙관적 업데이트: 실패 시 롤백 메커니즘 - AbortController: 요청 취소 기능 - notistack 통합: 사용자 피드백 제공 - ESC 키 지원: 다이얼로그 접근성 개선 테스트 결과: 528/528 통과 (100% 성공률) 포함된 수정사항: - recurringDelete 테스트에 시스템 시간 모킹 추가 - vite.config.ts에 testTimeout 10초로 증가 - DeleteConfirmDialog ESC 키 핸들링 구현 - 코드 리뷰 완료 (5/5 승인) ## Docs(11): Update FEAT(11) issue status to completed ### FEAT(11) 이슈 완료 상태로 업데이트 - 모든 TDD 단계 완료 표시 (RED-GREEN-REFACTOR) - 완료 기준 모든 항목 체크 - 구현 완료 요약 섹션 추가 - 최종 성과 및 통계 기록 - 상태: 완료로 변경
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#78