Skip to content

Conversation

sequba
Copy link
Contributor

@sequba sequba commented Oct 3, 2025

Context

When using Vue, sometimes the HyperFormula instance needs to be wrapped in the markRaw function to avoid Vue-specific automatic reactivity tweaks. I described it in the integration-with-vue guide.

Types of changes

  • Breaking change (a fix or a feature because of which an existing functionality doesn't work as expected anymore)
  • New feature or improvement (a non-breaking change that adds functionality)
  • Bug fix (a non-breaking change that fixes an issue)
  • Additional language file, or a change to an existing language file (translations)
  • Change to the documentation

Related issues:

  1. Fixes [Vue]: IF formula error  #1497

Checklist:

  • I have reviewed the guidelines about Contributing to HyperFormula and I confirm that my code follows the code style of this project.
  • I have signed the Contributor License Agreement.
  • My change is compliant with the OpenDocument standard.
  • My change is compatible with Microsoft Excel.
  • My change is compatible with Google Sheets.
  • I described my changes in the CHANGELOG.md file.
  • My changes require a documentation update.
  • My changes require a migration guide.

Copy link

github-actions bot commented Oct 3, 2025

Performance comparison of head (65f1f18) vs base (94d563b)

                                     testName |   base |   head | change
------------------------------------------------------------------------
                                      Sheet A | 522.32 | 523.45 | +0.22%
                                      Sheet B | 173.49 |  169.9 | -2.07%
                                      Sheet T | 152.24 | 148.97 | -2.15%
                                Column ranges | 518.08 | 518.67 | +0.11%
Sheet A:  change value, add/remove row/column |  14.93 |  15.59 | +4.42%
 Sheet B: change value, add/remove row/column | 137.58 | 129.65 | -5.76%
                   Column ranges - add column |  153.6 |  155.5 | +1.24%
                Column ranges - without batch | 450.92 | 457.57 | +1.47%
                        Column ranges - batch | 116.73 | 118.58 | +1.58%

@sequba sequba changed the title Decribe Vue reactivity issue and markRaw function as a solution in the Vue troubleshooting section Describe Vue reactivity issue and markRaw function as a solution in the Vue troubleshooting section Oct 3, 2025
@sequba sequba self-assigned this Oct 3, 2025
@sequba sequba requested a review from qunabu October 3, 2025 12:49
@sequba sequba marked this pull request as ready for review October 3, 2025 12:51
@sequba sequba merged commit 29178e5 into develop Oct 6, 2025
19 of 21 checks passed
@sequba sequba deleted the feature/issue-1497 branch October 6, 2025 08:42
Copy link

codecov bot commented Oct 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.22%. Comparing base (94d563b) to head (65f1f18).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1549   +/-   ##
========================================
  Coverage    97.22%   97.22%           
========================================
  Files          169      169           
  Lines        14523    14523           
  Branches      3169     3169           
========================================
  Hits         14120    14120           
  Misses         396      396           
  Partials         7        7           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants