-
Notifications
You must be signed in to change notification settings - Fork 137
Add unit test to make sure issue 1297 will not be introduced again #1535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Performance comparison of head (b4c7df6) vs base (29178e5)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about Missing JSDoc comment ?
@qunabu, where is it missing? |
![]() |
@qunabu, this is in the files unrelated to this PR
In total, there are 3192 eslint warnings in HyperFormula. I fix them one by one whenever I work on a file containing them. |
574b9b6
to
ac77614
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1535 +/- ##
========================================
Coverage 97.22% 97.22%
========================================
Files 169 169
Lines 14523 14524 +1
Branches 3169 3169
========================================
+ Hits 14120 14121 +1
Misses 396 396
Partials 7 7
🚀 New features to boost your workflow:
|
Context
Issue #1297 is not reproducible in HyperFormula 3.0.1. I am adding a unit test to ensure it will not be introduced again.
How did you test your changes?
unit tests, new unit test
Types of changes
Related issues:
Checklist: