add --agent pool option #164
Conversation
handshake-enthusiast
force-pushed
the
patch-3
branch
from
29df967 to
7e01bad
Compare
src/guides/config.md
Outdated
| @@ -91,6 +91,7 @@ Note that certain chain options affect the format and indexing of the chain data | |||
|
|
|||
| ### Pool Options | |||
|
|
|||
| - `agent`: Custom user agent (default: /hsd:version/). Must be not more than 255 characters long. | |||
There was a problem hiding this comment.
Agent doesn't replace the full user agent. It adds what's provided after /hsd:version/
Example: --agent bob-wallet:2.0.0 will make it /hsd:5.0.1/bob-wallet:2.0.0/
There was a problem hiding this comment.
Indeed, I know. How would you concisely rephrase this?
It's not said that this setting replaces the default, so seems to be correct, just not "complete".
There was a problem hiding this comment.
Stealing it from bitcoin core: https://github.com/bitcoin/bitcoin/blob/40e1c4d4024b8ad35f2511b2e10bf80c5531dfde/src/init.cpp#L574
And if a default is specified, it should probably be ""
There was a problem hiding this comment.
Good idea.
In Bitcoin Core it says "Append comment to the user agent string".
Do you like the following:
agent: Custom user agent comment (default is no comment). Example:--agent bob-wallet:2.0.0will make it/hsd:5.0.1/bob-wallet:2.0.0/while by default it's/hsd:5.0.1/. Must be not more than 255 characters long.
There was a problem hiding this comment.
tiny nit: should we clarify that the max length applies to the whole agent and not just the custom part?
There was a problem hiding this comment.
Indeed.
Do you like the following:
agent: Custom user agent comment (default is no comment). Example:--agent bob-wallet:2.0.0will make it/hsd:5.0.1/bob-wallet:2.0.0/while by default it's/hsd:5.0.1/. The whole user agent string must be not more than 255 characters long.
handshake-enthusiast
force-pushed
the
patch-3
branch
from
7e01bad to
efdee36
Compare
nodech
force-pushed
the
patch-3
branch
2 times, most recently
from
1a45104 to
efdee36
Compare
No description provided.