-
Notifications
You must be signed in to change notification settings - Fork 146
Go: improved coro-sine-sieve (add 2.go) #439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
? |
Sorry, this solution seems very different and incomparable to others. |
i ran the tests, it passes. it isn't at all different other than the fact that it avoids using channels, which are slow, and instead uses buffered i/o to improve the execution times. it's.. definitely the same thing. |
it's also quite apparent that the test cases that exist within the repository verify the consistency of the outputs as well... |
Hmm... Let me know the logic behind your decision! |
the primary difference here that results in increased performance is dropping the usage of channels, which are quite slow, in favor of buffered I/O. If you'd like, I can make a version of this that is closer to the original that only implements said change. |
Old:
1.go
New:
2.go
(this PR)