Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(crypto/hash): Improved throw messages #11

Merged
merged 2 commits into from
Dec 29, 2024
Merged

fix(crypto/hash): Improved throw messages #11

merged 2 commits into from
Dec 29, 2024

Conversation

halvardssm
Copy link
Owner

@halvardssm halvardssm commented Dec 28, 2024 •
edited
Loading

Improved the throw messages to use JS throw instead of Rust panic

Closes #10

@halvardssm halvardssm force-pushed the fix/crypto-hash-improved-throws branch from 2cac944 to c9878d1 Compare December 28, 2024 18:59
@halvardssm halvardssm mentioned this pull request Dec 28, 2024
Closed
brettchalupa
brettchalupa reviewed Dec 28, 2024
View reviewed changes
Copy link

@brettchalupa brettchalupa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you! Really cool to see the diff too in the library code + Rust.

@halvardssm halvardssm merged commit 7ce38a6 into main Dec 29, 2024
8 checks passed
@halvardssm halvardssm deleted the fix/crypto-hash-improved-throws branch December 29, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettchalupa brettchalupa brettchalupa left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Calling verify from stdext/crypto/hash with argon2 without a hashed value panics
2 participants
@halvardssm @brettchalupa