Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop ed & reverse_ed formats #108

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Annih
Copy link
Contributor

@Annih Annih commented Jan 31, 2025

These formats are super old and very unlikely used. Their implementation was broken for a while and no-one reported it.

The GNU doc say that ed format is "almost obsolete". 1
The reverse_ed (aka forward-ed) is described as "not very useful". 2

This is just a suggestion, but IMHO this will simplify the maintenance 🤷🏻‍♂️ feel free to close!

These formats are super old and very unlikely used.
Their implementation was broken for a while and no-one reported it.

The GNU doc say that ed format is "almost obsolete". [1]
The reverse_ed (aka forward-ed) is described as "not very useful". [2]

[1]: https://www.gnu.org/software/diffutils/manual/html_node/ed-Scripts.html
[2]: https://www.gnu.org/software/diffutils/manual/html_node/Forward-ed.html
@Annih Annih force-pushed the drop_ed_format_support branch from 5298695 to 5716d6f Compare January 31, 2025 16:22
@halostatue
Copy link
Owner

I will leave this open, but I can't do this without a major version bump, so it's not happening for a while.

@Annih
Copy link
Contributor Author

Annih commented Jan 31, 2025

OK, no problem. I thought you could have released a major breaking version just for that 🤷🏻

Anyway, if we merge #101 at some point, I'll rebase & update this one accordingly.

@halostatue
Copy link
Owner

I'm not against a major version, but there are other changes we want to do with such a release, because the main user of diff-lcs is rspec, so I need to do more research on this.

@halostatue
Copy link
Owner

There will be a v2 in 2025. I can commit to that much right now. I don't want to support long-EOLed versions of Ruby anymore.

@Annih
Copy link
Contributor Author

Annih commented Feb 2, 2025

There will be a v2 in 2025. I can commit to that much right now. I don't want to support long-EOLed versions of Ruby anymore.

I think this is a good idea 👍🏻 there is no emergency anyway.

I'm not against a major version, but there are other changes we want to do with such a release, because the main user of diff-lcs is rspec, so I need to do more research on this.

Note that they use (mostly?) :unified format.
Also, based on my bug findings (#100, #102, #106, #107) as well as #95, I think most of the gem users are only using it to display a human readable diff, without verifying the patch is valid or not.

To give you more context on my use case and why I really want to fix the :unified format: I'm generating file patches that must be valid to be applied by Gerrit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants