Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve style compatibility issues for the copy button #31

Merged
merged 1 commit into from
Sep 27, 2024
Merged

fix: resolve style compatibility issues for the copy button #31

merged 1 commit into from
Sep 27, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Sep 26, 2024

修复复制按钮在低版本浏览器下的兼容问题。

可测试插件：plugin-highlightjs-1.0.0-SNAPSHOT.jar.zip

Fixes #18
Fixes #17

/kind bug

修复复制按钮在低版本浏览器下的兼容问题。

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 26, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and JohnNiang September 26, 2024 09:32
@ruibaby ruibaby mentioned this pull request Sep 26, 2024
Closed
@verkyer
Copy link

verkyer commented Sep 26, 2024

修复复制按钮在低版本浏览器下的兼容问题。

可测试插件：plugin-highlightjs-1.0.0-SNAPSHOT.jar.zip

Fixes #18 Fixes #17

/kind bug

修复复制按钮在低版本浏览器下的兼容问题。

image

可以了，但是切换高亮主题不生效

@ruibaby
Copy link
Member Author

ruibaby commented Sep 26, 2024

可以了，但是切换高亮主题不生效

哪里不生效，我看按钮的样式是正常的。

@verkyer
Copy link

verkyer commented Sep 26, 2024

可以了，但是切换高亮主题不生效

哪里不生效，我看按钮的样式是正常的。

image
这里切换后，实际没有生效，都是白色的；
旧版本可以生效

@ruibaby
Copy link
Member Author

ruibaby commented Sep 26, 2024

可以了，但是切换高亮主题不生效

哪里不生效，我看按钮的样式是正常的。

image 这里切换后，实际没有生效，都是白色的； 旧版本可以生效

我没有复现这个问题，理论上这个改动和这个问题也没有关系，建议打开浏览器开发者工具看看样式是否正确加载。

@verkyer
Copy link

verkyer commented Sep 26, 2024

可以了，但是切换高亮主题不生效

哪里不生效，我看按钮的样式是正常的。

image 这里切换后，实际没有生效，都是白色的； 旧版本可以生效

我没有复现这个问题，理论上这个改动和这个问题也没有关系，建议打开浏览器开发者工具看看样式是否正确加载。

可以了 缓存问题

JohnNiang
JohnNiang approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2024
@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 016f671 into halo-sigs:main Sep 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnNiang JohnNiang JohnNiang approved these changes

@guqing guqing Awaiting requested review from guqing

Assignees

@JohnNiang JohnNiang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

复制按钮不显示 无复制按钮
3 participants
@ruibaby @verkyer @JohnNiang