Skip to content

Commit

Permalink
Cleanup allocated dns runtime data
Browse files Browse the repository at this point in the history
While harmless, the runtime should clean up non-user allocated data.
On the same veign of: odin-lang#4680

I'm kinda new to Odin and wrote netcat, in order to get a clean valgrind run,
one has to manually destroy dns_configuration:
https://github.com/haesbaert/learn-odin/blob/main/netcat/netcat.odin#L168-L169

While here unexport the destroy procedure and make destruction idempotent.
  • Loading branch information
haesbaert committed Feb 8, 2025
1 parent 0683a3d commit cd53949
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions core/net/dns.odin
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,12 @@ init_dns_configuration :: proc() {
dns_configuration.hosts_file, _ = replace_environment_path(dns_configuration.hosts_file)
}

@(fini, private)
destroy_dns_configuration :: proc() {
delete(dns_configuration.resolv_conf)
dns_configuration.resolv_conf = ""
delete(dns_configuration.hosts_file)
dns_configuration.hosts_file = ""
}

dns_configuration := DEFAULT_DNS_CONFIGURATION
Expand Down

0 comments on commit cd53949

Please sign in to comment.