feat: new lsm module #249
Open
feat: new lsm module #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ratik
force-pushed
the
feat/new-lsm-for-datom
branch
15 times, most recently
from
c92e71e to
10853c0
Compare
ratik
force-pushed
the
feat/new-lsm-for-datom
branch
from
10853c0 to
6d05eae
Compare
Comment on lines
+10
to
+15
| case "$ARCH" in \ | ||
| x86_64) PLATFORM="x86_64" ;; \ | ||
| aarch64) PLATFORM="aarch64" ;; \ | ||
| *) echo "Unsupported architecture: $ARCH" && exit 1 ;; \ | ||
| esac && \ | ||
| TARNAME="hermes-${HERMES_VERSION}-${PLATFORM}-unknown-linux-gnu.tar.gz" && \ |
There was a problem hiding this comment.
we should compare it with aarch64 only
Comment on lines
+10
to
+15
| case "$ARCH" in \ | ||
| x86_64) PLATFORM="x86_64" ;; \ | ||
| aarch64) PLATFORM="aarch64" ;; \ | ||
| *) echo "Unsupported architecture: $ARCH" && exit 1 ;; \ | ||
| esac && \ | ||
| TARNAME="hermes-${HERMES_VERSION}-${PLATFORM}-unknown-linux-gnu.tar.gz" && \ |
Comment on lines
+13
to
+17
| if [ "$ARCH" = "arm64" ] || [ "$ARCH" = "aarch64" ]; then | ||
| DOCKERFILE="Dockerfile.aarch64" | ||
| else | ||
| DOCKERFILE="Dockerfile.x86_64" | ||
| fi |
There was a problem hiding this comment.
btw the only difference between these two containers are in base image (ubuntu:24.04 vs ubuntu:20.04)
Maybe we can build docker based on common platform and remove docker containers selection?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.