Skip to content

Enable pdb_splitmodel to handel more than 9999 models #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ntxxt
Copy link

@ntxxt ntxxt commented Mar 25, 2025

To solve this #170 issue

Copy link
Member

@joaomcteixeira joaomcteixeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally disagree with this for the same reason expressed by @JoaoRodrigues here:

#170 (comment)

However, I understand what @amjjbonvin argued after. Still, I disagree with this PR as it deviates from the official PDB format. Users can quickly create their branch to apply this change locally if needed.

In any case, if this PR is to be accepted it should be as @JoaoRodrigues said afterwards in the issue and not in the current form of line[6:].

Good point, I'd still keep then the model number starting at position 11 but open-ended. Otherwise you will indeed parse bad files with numbers where they should not be and they might be interpreted wrong by different tools, e.g.

Cheers!

@amjjbonvin
Copy link
Member

amjjbonvin commented May 7, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants