create libfcc.py
#1019
Merged
create libfcc.py
#1019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvhonorato
added
CI / repository
amjjbonvin
approved these changes
Sep 12, 2024
VGPReys
approved these changes
Sep 12, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines.
Checklist
Summary of the Pull Request
This PR moves the fcc-related code to a new
libfcc.pyRelated Issue
needed for #1013 (PR)
Additional Info
haddock3 uses the fcc code as a submodule. Considering this algorithm does not chance (last change was 4 years ago) and this is also our codebase, it makes things simpler to have the code directly in the haddock3 project.
In this PR I've kept the submodule, as it's needed for the binaries - but I updated the imports to use the
libfccinstead of the submodule.In #1013 will handle the binaries and remove the submodule definition.