Skip to content

Issue146 OIDC plan april #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ale210 merged 8 commits into from
May 21, 2026
Merged

Issue146 OIDC plan april #154

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3c42848
Separate Terraform plan and apply roles for incubator
Benettonkkb Feb 5, 2026
ca2eae6
Applying recommended role detail changes for plan and apply
Benettonkkb Feb 26, 2026
d62db78
Removed Pull Request condition from incubator_tf_apply
Benettonkkb Mar 12, 2026
401f503
new TF Plan read policy for secrets manager and fixed lines
Benettonkkb Apr 2, 2026
dabde0c
Merge main into issue146-oidc-plan-april and resolve OIDC provider co…
Benettonkkb Apr 15, 2026
f2eb239
Executed feedback: generalized custom policy .json and home-unite-us …
Benettonkkb Apr 29, 2026
e54f538
Previous push rejected for deprecated aws resource. Fixed, and aligne…
Benettonkkb Apr 29, 2026
028e4e2
Add DynamoDB TF Plan policy entries
Benettonkkb May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions terraform/aws-custom-policies.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,9 @@ module "aws_custom_policies" {
description = "Policy enforcing MFA for devops security users"
filename = "enforce-mfa-for-users-policy.json"
}
"IncubatorTfPlanSecretsRead" = {
description = "Allows incubator tf plan role to read specific Secrets Manager secrets needed for terraform plan"
filename = "incubator-tf-plan-secrets-read-policy.json"
}
Comment thread
ale210 marked this conversation as resolved.
}
}
17 changes: 17 additions & 0 deletions terraform/aws-custom-policies/incubator-tf-plan-secrets-read-policy.json
View file
Open in desktop
Comment thread
Benettonkkb marked this conversation as resolved.
Outdated
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
{
"Version": "2012-10-17",
"Statement": [
{
"Sid": "AllowReadSpecificSecretsForTerraformPlan",
"Effect": "Allow",
"Action": [
"secretsmanager:GetSecretValue"
],
"Resource": [
"arn:aws:secretsmanager:us-west-2:035866691871:secret:home-unite-us-cognito-client*",
Comment thread
Benettonkkb marked this conversation as resolved.
Outdated
"arn:aws:secretsmanager:us-west-2:035866691871:secret:home-unite-us-google-clientid*",
"arn:aws:secretsmanager:us-west-2:035866691871:secret:home-unite-us-google-secret*"
]
}
]
}
8 changes: 6 additions & 2 deletions terraform/aws-gha-oidc-providers.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,17 @@ resource "aws_iam_role" "incubator_tf_plan" {
}

resource "aws_iam_role_policy_attachment" "incubator_tf_plan_readonly" {
role = aws_iam_role.incubator_tf_plan.name
role = aws_iam_role.incubator_tf_plan.name
policy_arn = "arn:aws:iam::aws:policy/ReadOnlyAccess"
}
Comment thread
ale210 marked this conversation as resolved.

resource "aws_iam_role_policy_attachment" "incubator_tf_plan_secrets_read" {
role = aws_iam_role.incubator_tf_plan.name
policy_arn = module.aws_custom_policies.policy_arns["IncubatorTfPlanSecretsRead"]
}

resource "aws_iam_role" "incubator_tf_apply" {
name = "incubator-tf-apply"

assume_role_policy = jsonencode({
Version = "2012-10-17"
Statement = [
Expand Down
Loading