Repository navigation
feat(certification): support hardware triage without an extension - #1617
Draft
lordbagel42 wants to merge 1 commit into
Draft
lordbagel42 wants to merge 1 commit into
lordbagel42 wants to merge 1 commit into
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-01a1c607-6d52-747b-a570-38d7fb1bd5eb Co-authored-by: Amp <amp@ampcode.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what's this do?
Hardware reviewers no longer need SDHWEX installed: Stardance shows its design/build findings and warnings, copies feedback drafts (with a manual-copy fallback), and inserts shipping guidelines into rejection justifications. Bundles the current 175 design / 237 build records with their original November 4 check dates; no live checks, Cloudflare dependency, migration, or editing interface now that submissions are closed.
Findings stay advisory. Unknown projects/stages never get a fabricated verdict, and these tools don't submit reviews or change claim/approval/rejection behavior.
show it works
Ran locally in an orb against a fresh PostgreSQL test database, with development-only users/projects; no production reviews were changed. The surrounding project header uses local fixture values, while the triage card preserves the actual snapshot values.
bin/rails test test/controllers/admin/certification/hardware_reviews_controller_test.rb test/controllers/admin/certification/review_notes_controller_test.rb test/controllers/admin/missions/hardware_reviews_controller_test.rb— passed.beforeinput, readonly/disabled fields, keyboard activation, and Turbo/back navigation without duplicates or submission. Inspected desktop and 390px layouts.Build, ready, unknown, clipboard fallback, and narrow layouts
ai?
Amp, including an Oracle planning/code-review pass. https://ampcode.com/threads/T-01a1c607-6d52-747b-a570-38d7fb1bd5eb