Skip to content

feat(certification): support hardware triage without an extension - #1617

Draft
lordbagel42 wants to merge 1 commit into
hackclub:mainfrom
lordbagel42:feat/native-hardware-triage
Draft

lordbagel42 wants to merge 1 commit into
hackclub:mainfrom
lordbagel42:feat/native-hardware-triage

Conversation

@lordbagel42

Copy link
Copy Markdown
Collaborator

what's this do?

Hardware reviewers no longer need SDHWEX installed: Stardance shows its design/build findings and warnings, copies feedback drafts (with a manual-copy fallback), and inserts shipping guidelines into rejection justifications. Bundles the current 175 design / 237 build records with their original November 4 check dates; no live checks, Cloudflare dependency, migration, or editing interface now that submissions are closed.

Findings stay advisory. Unknown projects/stages never get a fabricated verdict, and these tools don't submit reviews or change claim/approval/rejection behavior.

show it works

Ran locally in an orb against a fresh PostgreSQL test database, with development-only users/projects; no production reviews were changed. The surrounding project header uses local fixture values, while the triage card preserves the actual snapshot values.

  • bin/rails test test/controllers/admin/certification/hardware_reviews_controller_test.rb test/controllers/admin/certification/review_notes_controller_test.rb test/controllers/admin/missions/hardware_reviews_controller_test.rb — passed.
  • Temporary Rails checks rendered all 412 records and compared exact findings, warnings, dates and feedback drafts; checked stage isolation, missing IDs, safe links and standalone rejection-form exclusion. No generated tests committed.
  • Chromium exercised clipboard success/denial, cursor/selection replacement, exact/over-limit insertion, canceled beforeinput, readonly/disabled fields, keyboard activation, and Turbo/back navigation without duplicates or submission. Inspected desktop and 390px layouts.
  • Scoped RuboCop/ERB lint, Prettier, JS and Sass builds passed. Rendered lintapple checks found no triage-card findings; existing page-wide findings and one unresolved narrow-modal status contrast measurement remain. The modal was also visually inspected.

Design triage

Copy and guidelines insertion demo

Build, ready, unknown, clipboard fallback, and narrow layouts

Build triage

Ready is not approval

Unknown snapshot project

Clipboard fallback

Guidelines insertion

Narrow design triage

Narrow rejection helper

ai?

Amp, including an Oracle planning/code-review pass. https://ampcode.com/threads/T-01a1c607-6d52-747b-a570-38d7fb1bd5eb

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant