Repository navigation
fix(hardware): apply the recertification shutdown to funding requests - #1615
Merged
lordbagel42 merged 1 commit intoNov 10, 2026
Merged
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-01a1c5fc-274f-75c7-b914-57bbdd7788f6 Co-authored-by: Amp <amp@ampcode.com>
lordbagel42
marked this pull request as ready for review
November 10, 2026 15:29
destroyer796
added a commit
to destroyer796/stardance
that referenced
this pull request
Nov 10, 2026
Keeps both conditions where hackclub#1615 closed funding after Stardance ended and this branch hides funding on projects moved to Fabricate. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XbGbYWLS3Kapvu7Ny5YaKr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what's this do?
Hardware funding resubmissions were still getting through after re-certifications closed. Apply
disable_recertificationto funding requests too, including stale/direct submissions, and hide the submit controls while closed. Keeps the existing admin exception and leaves pending reviews alone.show it works
Temporary integration checks reproduced accepted requests before the fix; all four checks pass after it (first/repeat submissions blocked, closed-page controls removed, admin exception preserved). No generated tests included. RuboCop and ERB lint pass; Oracle review found no blockers.
The existing funding/recertification controller tests have the same six failures on unchanged HEAD and this patch (missing demo links, public funding-card visibility, vote-cost expectation). Rendered checks confirm the closed action is natively disabled and the funding form/resubmit action is absent at desktop and narrow widths. Lintapple also ran; its page-wide report is not clean, including unrelated existing controls and typography-policy mismatches. No styling changed.
Closed:
Narrow viewport:
Admin exception:
ai?
Amp, including an Oracle subagent review. https://ampcode.com/threads/T-01a1c5fc-274f-75c7-b914-57bbdd7788f6