fix: fix local storage check for us prices (check '1' rather than 1)
#1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Duro <[email protected]>
DuroCodes
requested review from
malted,
maxwofford and
polytroper
as code owners
|
@DuroCodes is attempting to deploy a commit to the Hack Club Team on Vercel. A member of the Team first needs to authorize it. |
|
Nice catch! thanks for submitting this |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
maxwofford
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently it shows incorrect "... doubloons until next prize" since it uses global prices—even when the us region is selected:
this is due to the local storage checking the result for
1rather than'1', since the local storage has the number stringified:Note
maybe it would make more sense to use their selected region rather than just us/global?