-
Notifications
You must be signed in to change notification settings - Fork 36
Improve card grant modal behavior #10253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Improve card grant modal behavior #10253
Conversation
I couldn't get the modal to close when opening the next one. closeExisiting just hides the entire div. |
Can you send me the code you had? I can give it a shot |
https://github.com/hackclub/hcb/tree/1bf6952679938c45a4553f00f3d40bb3ebee2f49 this is after the "Small tweaks" commit. It got it to a separate modal and form but they were stacking on top of each other. |
I figured it out! It's a bug with The problem is we having fading setup - so when you call close(), it doesn't immediately close it but queues the close() function to run in 10 seconds, but the close function closes all modals. So once the new one is opened, they both get closed. Here's how I fixed it: https://github.com/hackclub/hcb/tree/fix-jquery-modal |
This reverts commit 810f768.
This reverts commit e35483f.
This reverts commit c83b1ae.
Co-authored-by: Sam Poder <[email protected]>
It worked! Thank you! |
9140307
to
02efd22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work here @Luke-Oldenburg and @sampoder !
It should auto merge after you resolve merge conflicts |
Co-authored-by: Sam Poder <[email protected]>
Switched from jquery refresh after doing turbo to using js to hide and reveal it with a back button. Works much smoother and faster. Only issue is the back button looks a little out of place.