[Feature] Issue a new card #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedev132
force-pushed
the
thedev132/cardcreation
branch
from
48e806d to
bd45934
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request implements card ordering functionality in a React Native mobile application, enabling users to create both virtual and physical cards through a new OrderCard screen. It also improves the cards list page with enhanced filtering options and fixes various authentication and state management issues.
Key changes:
- Adds a new OrderCard screen with organization selection, card type choice, shipping address input, and card design selection
- Implements field validation and card creation API integration
- Enhances cards filtering to include both canceled and frozen cards toggle
- Improves authentication token refresh handling with request queueing
- Adds error retry logic with exponential backoff for SWR requests
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| src/pages/cards/OrderCard.tsx | New screen for ordering cards with organization selection, card type, shipping info, and design selection |
| src/utils/cardHelpers.ts | New utility file containing field validation logic for card creation |
| src/utils/cardActions.ts | Adds handleCreateCard function for card creation API call |
| src/pages/cards/cards.tsx | Adds frozen cards filter toggle and navigation button to order cards |
| src/pages/cards/GrantCard.tsx | Fixes activate button visibility to only show for card holder |
| src/lib/client.ts | Refactored token refresh logic with global state and request queueing |
| src/lib/useOfflineSWR.ts | Adds retry logic with exponential backoff for failed requests |
| src/core/AppContent.tsx | Adds custom error retry handler to SWR config |
| src/lib/types/User.ts | Adds shipping_address field and reader role to user types |
| src/lib/types/CardDesign.ts | New type definition for card designs |
| src/lib/NavigatorParamList.ts | Adds OrderCard route to navigation types |
| src/core/Navigator.tsx | Registers OrderCard screen in navigation stack |
| src/components/PaymentCard.tsx | Fixes card logo tint color to show black on non-black cards |
| src/components/ReceiptActionSheet.tsx | Adds anchor positioning for action sheet |
| src/components/receipts/MissingReceiptTransaction.tsx | Passes button ref to action sheet for proper positioning |
| src/components/transaction/ReceiptList.tsx | Passes button ref to action sheet for proper positioning |
| src/pages/Receipts.tsx | Passes button ref to action sheet for proper positioning |
| src/components/cards/RepIcon.tsx | New SVG icon component for virtual cards |
| src/components/cards/CardIcon.tsx | New SVG icon component for physical cards |
| src/auth/AuthProvider.tsx | Removes duplicate error logging during token refresh |
| src/Navigator.tsx | Duplicate/alternative Navigator file with OrderCard registration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Issues attributed to commits in this pull requestThis pull request was merged and Sentry observed the following issues:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.