HFP-3655 Improve a11y focus on "Check" and "Show Solutions" #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged in, will introduce the same focus behavior that was introduced for Multiple Choice in HFP-3554: For both "Check" and "Show Solution" move the focus to the first answer. When calling
showSolutionsprogramatically, e.g. by a parent content type, the focus is not set.note
There's a bug in H5P.Question that will make this pull request read a "dot" in between strings that are read to screen readers - fixed separately in h5p/h5p-question#16, see HFP-3654
background
Currently, the behavior of Fill in the Blanks is inconsistent.
When clicking on "Check", the focus will be given to an invisible and non-tabbable element above the cloze in order to announce "Checking Mode" and to allow tabbing forward through the given answers.
When clicking on "Show solution", the focus will be set to the retry button (by H5P.Question). The input fields are disabled and non-tabbable, so here the user would need to navigate backwards (not tabbing) in order to learn about the correct solutions.