Skip to content

feat: add assertBodySize util and bodyLimit middleware #1222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Oct 25, 2025
Merged

feat: add assertBodySize util and bodyLimit middleware #1222

merged 14 commits into from
Oct 25, 2025

Conversation

@aquapi
Copy link
Contributor

@aquapi aquapi commented Oct 15, 2025

resolves #1221

@aquapi aquapi requested a review from pi0 as a code owner October 15, 2025 15:00
@aquapi
Copy link
Contributor Author

aquapi commented Oct 15, 2025

I need to add tests for this feature as well
We can get some tests from Hono: https://github.com/honojs/hono/blob/main/src/middleware/body-limit/index.test.ts

@aquapi
Copy link
Contributor Author

aquapi commented Oct 25, 2025

@pi0 do u think I should add more tests

@pi0 pi0 changed the title Add request body size limit utility and middleware feat: add assertBodySize util and bodyLimit middleware Oct 25, 2025
pi0
pi0 approved these changes Oct 25, 2025
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❤️

@pi0 pi0 merged commit 412bba4 into h3js:main Oct 25, 2025
3 checks passed
@pi0
Copy link
Member

pi0 commented Oct 25, 2025

Now we can add it a a Nitro v3 route rule even!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pi0 pi0 pi0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add request body size limit utility and middleware

2 participants

@aquapi @pi0