Skip to content

feat(readBody): support formdata type #1164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(readBody): support formdata type #1164

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ae3a86
check for multipart/form-data
huseeiin Jul 18, 2025
4eb062b
fix
huseeiin Jul 22, 2025
67b3884
Merge branch 'main' into multipart-form-data
pi0 Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/utils/body.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,17 @@ export async function readBody<
_Event extends HTTPEvent = HTTPEvent,
_T = InferEventInput<"body", _Event, T>,
>(event: _Event): Promise<undefined | _T> {
const contentType = event.req.headers.get("content-type") || "";

if (contentType.startsWith("multipart/form-data"))
Copy link
Member

@pi0 pi0 Jul 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make it opt-in by supporting event, opts?: { type: "json" | formData" } and throw an HTTPError if it is not.

Copy link
Contributor Author

@huseeiin huseeiin Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make it opt-in by supporting event, opts?: { type: "json" | formData" } and throw an HTTPError if it is not.

i support this. but my changes remain valid, right? since opts is optional. when you specify type in opts, you're specifying a certain body type, when you're not, you're parsing any body as an object or string!

Copy link
Member

@pi0 pi0 Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As security measure we should make types opt-in other than JSON (so if no options only json)

Copy link
Member

@pi0 pi0 Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Context: #875

return Object.fromEntries(await event.req.formData()) as _T;

const text = await event.req.text();

if (!text) {
return undefined;
}

const contentType = event.req.headers.get("content-type") || "";
if (contentType.startsWith("application/x-www-form-urlencoded")) {
return parseURLEncodedBody(text) as _T;
}
Expand Down