Skip to content

fix(sendStream): handle stream abortion #1047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: v1
Choose a base branch
from
Open

fix(sendStream): handle stream abortion #1047

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aeafba5
fix(sendStream): handle aborted (endless) streams correctly
May 3, 2025
c5c4e4b
chore: apply automated updates
autofix-ci[bot] May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/utils/response.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,13 +414,29 @@ export function sendStream(
hasProp(stream, "pipeTo") &&
typeof (stream as ReadableStream).pipeTo === "function"
) {
// instantiate a new AbortController to handle request aborts
const abortController = new AbortController();

// shared function to handle aborts
const doAbort = () => {
abortController.abort("Client closed or lost connection.");
};

// Handle request aborts
event.node.res.on("close", doAbort);
event.node.res.on("finish", doAbort);
event.node.res.on("error", doAbort);

return (stream as ReadableStream)
.pipeTo(
new WritableStream({
write(chunk) {
event.node.res.write(chunk);
},
}),
{
signal: abortController.signal,
},
)
.then(() => {
event.node.res.end();
Expand Down