Skip to content

Conversation

@matheus-wh
Copy link
Collaborator

@matheus-wh matheus-wh commented Oct 24, 2025

JIRA Issue

Description 📄

Include Andorra flag icon from https://www.figma.com/design/4wVcesj6nT2uYVJoq5g5Dn/2-%E2%80%A2-Yoga---Icons---Ilustrations?node-id=3906-372&m=dev

Platforms 📲

  • Web
  • Mobile

Type of change 🔍

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? 🧪

[Enter the tips to test this PR]

  • Unit Test
  • Snapshot Test

Checklist: 🔍

  • My code follows the contribution guide of this project Contributing Guide
  • Layout matches design prototype: FIGMA
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Screenshots 📸

image

@@ -1,21 +1,18 @@
<svg width="12" height="12" viewBox="0 0 12 12" fill="none" xmlns="http://www.w3.org/2000/svg">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default I think the flag icons are all 12x12

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed! thank you

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 24, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
3 Security Hotspots

See analysis details on SonarQube Cloud

@flaviafmoraes flaviafmoraes merged commit 9be4a63 into master Oct 24, 2025
2 of 3 checks passed
@flaviafmoraes flaviafmoraes deleted the DS-1324 branch October 24, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants