Fix in-flight key cache bug, stale docs, and dead workflow code#6
Merged
Conversation
Bugs: - In-flight recovery with cached keys: was re-fetching keys from network instead of building swap directly with cached keyset. Now builds swap inline when keys are cached, skipping HTTP round-trip. - In-flight recovery with empty mint URL: was storing tokens under empty string key in wallet. Now logs warning and discards (this case shouldn't occur since wallet keys always have mint URLs). Documentation: - Fix crypto comment: was "HMAC-SHA256", actually SHA-256(key || ct) - README signature example: updated to show encrypted format (ecash-ciphertext, ecash-ephemeral-pubkey, ecash-mac) - README: add missing /vitriol/admin/withdraw endpoint to table Workflow: - Remove dead mint: field extraction (mint URL is inside encrypted payload, not a separate signature block field) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Code review follow-up from #5.
''wallet key, effectively losing themSHA-256(mac_key || ciphertext)/vitriol/admin/withdrawendpointmint:field extraction (mint URL is inside encrypted payload)Test plan
🤖 Generated with Claude Code