Merge upstream develop into gw/next/kelvin/408#47
Merged
Conversation
+await-thread +sleeps for 0 seconds (this presumably copied over from +start-thread-with-args) right after starting a thread. While at the surface this looks correct: we want to transfer control back to spider, so that it can start running the newly started thread, this does not work in practice, as it assumes the spawned thread must do some io during its execution, which is not guaranteed. A trace of the sleep strand, used in +await-thread, reveals the following inputs: 1. It firsts receives a null input. This is expected, and causes the control to transfer back to spider. 2. The spider now runs the thread. Crucially, if the thread *runs continuously* (as the `-test` thread does, for instance), it will complete, producing a result without transferring control back to spider until execution finished. 3. The sleep strand now receives the thread result fact and a kick from spider, and skips them, because it is awaiting a wake sign from behn. 4. The +await-thread now hangs, waiting in vain for the thread result fact which was already consumed in step. Unlike in +start-thread-with-args, there is no need to artificially transfer control in +await-thread. The +take-fact strand following the +poke-our call to spider is enough for that.
ames: refactor |ahoy flow
ames: give %done error on %mate failure
`sessions.auth.server-state` is a map, not a set, so we should use the corresponding utilities. Probably didn't matter in practice in this particular case, but an oversight is an oversight and should be corrected.
mesa: migrate and handle halted flows
eyre: +tap:by the map, not +tap:in
ames: add %mesa migration version 2
spider: cache marks
and add pending acks
here we can display bot the user-level path, and the namespace binding associated with it
dbug: update /~debug dashboard with %mesa state
ames: fully check test $ahoy path
eyre: prevent .local domains overriding eauth public domains
strandio: fix +await-thread to stop using +sleep
dojo: fix poke perm check for dojo linking
Merge develop into next/kelvin/408
Merge next/kelvin/408 to develop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.